fix(tui): show shells from session location - #39691
Merged
Merged
Conversation
kitlangton
enabled auto-merge (squash)
July 30, 2026 16:02
kitlangton
disabled auto-merge
July 30, 2026 16:29
kitlangton
enabled auto-merge (squash)
July 30, 2026 16:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the session composer Shell tab showing “No shell commands” when a background shell is running from a session whose location differs from the TUI bootstrap directory.
Before / After
Before
The background shell starts successfully and appears in the transcript, but the Shell tab begins with the bootstrap location’s shell collection and renders empty:
After
The Shell tab asks the TUI data context for active shells belonging to the current session across hydrated locations:
How
data.shell.listBySession(sessionID)scans the TUI’s live location shell collections and filters by the existingmetadata.sessionIDassociation.ShellTabconsumes that session-first read model, then limits the view to running shells.Scope
This fixes live TUI behavior across every hydrated location. A reconnect where the session still owns a shell in an old location that has not been rehydrated would require a server-side session-scoped active-shell query; that API question is being discussed separately.
Testing
bun typecheckinpackages/tui: clean.v2and this branch. The baseline reproduced “No shell commands”; the fix displayedsleep 30and restored the kill action.