fix(tui): remove shells from their location - #39885
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove a running shell through the location that owns it, even when the TUI is currently displaying another project location.
This follows up on #39691, which made session shells visible across loaded locations but left shell removal scoped to the current location.
Before / After
Before
After
LocationRef.How
packages/tui/src/context/data.tsxstores shell location provenance for API results andshell.createdevents.packages/tui/src/routes/session/composer/shell-tab.tsxremoves the selected shell through that stored location.packages/tui/test/cli/tui/data.test.tsxloads one session's shells from two locations, triggers the composer kill command, and verifies the DELETE query uses the owning directory and workspace. It also covers live-event provenance.Scope
This does not change shell creation, synchronization ownership, or the server shell API.
Testing
cd packages/tui && bun run test(575 passed, 5 skipped)cd packages/tui && bun typecheckbun turbo typecheck --concurrency=3(33 tasks passed)