Skip to content

FIX: stackup.py roughness import#1985

Merged
maxcapodi78 merged 3 commits intomainfrom
xml-import
Apr 2, 2026
Merged

FIX: stackup.py roughness import#1985
maxcapodi78 merged 3 commits intomainfrom
xml-import

Conversation

@hui-zhou-a
Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions bot added testing Anything related to testing grpc-transition Changes that need to be included in gRPC transition labels Apr 2, 2026
@hui-zhou-a
Copy link
Copy Markdown
Collaborator Author

close #1978

@codacy-production
Copy link
Copy Markdown

codacy-production bot commented Apr 2, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics -1 duplication

Metric Results
Duplication -1

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.91%. Comparing base (5cbae21) to head (29c03a8).
⚠️ Report is 61 commits behind head on main.

❌ Your patch status has failed because the patch coverage (37.50%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1985       +/-   ##
===========================================
- Coverage   70.20%   48.91%   -21.30%     
===========================================
  Files         261      263        +2     
  Lines       42416    42976      +560     
===========================================
- Hits        29779    21021     -8758     
- Misses      12637    21955     +9318     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you are adding line in xml file for roughness and etching but there is no test code associated. Can you also make sure it's working both on grpc and dotnet ?

Copy link
Copy Markdown
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see changes in xml bot not additionnal testing code. We also need to be sure grpc is passing.

@maxcapodi78 maxcapodi78 merged commit 9347f8e into main Apr 2, 2026
25 checks passed
@maxcapodi78 maxcapodi78 deleted the xml-import branch April 2, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

grpc-transition Changes that need to be included in gRPC transition testing Anything related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants