Conversation
|
close #1978 |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | -1 |
TIP This summary will be updated as you push new changes. Give us feedback
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (37.50%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1985 +/- ##
===========================================
- Coverage 70.20% 48.91% -21.30%
===========================================
Files 261 263 +2
Lines 42416 42976 +560
===========================================
- Hits 29779 21021 -8758
- Misses 12637 21955 +9318 🚀 New features to boost your workflow:
|
svandenb-dev
left a comment
There was a problem hiding this comment.
I see you are adding line in xml file for roughness and etching but there is no test code associated. Can you also make sure it's working both on grpc and dotnet ?
svandenb-dev
left a comment
There was a problem hiding this comment.
I see changes in xml bot not additionnal testing code. We also need to be sure grpc is passing.
No description provided.