Skip to content

FIX: grpc import xml with roughness#1986

Merged
svandenb-dev merged 3 commits intomainfrom
grpc-import-roughness
Apr 2, 2026
Merged

FIX: grpc import xml with roughness#1986
svandenb-dev merged 3 commits intomainfrom
grpc-import-roughness

Conversation

@hui-zhou-a
Copy link
Copy Markdown
Collaborator

@hui-zhou-a hui-zhou-a commented Apr 2, 2026

roughness import for gprc. Same as #1985

closes #1978

svandenb-dev
svandenb-dev previously approved these changes Apr 2, 2026
Copy link
Copy Markdown
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svandenb-dev svandenb-dev enabled auto-merge (squash) April 2, 2026 15:54
@codacy-production
Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 1 duplication

Metric Results
Duplication 1

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

@svandenb-dev svandenb-dev disabled auto-merge April 2, 2026 15:58
@svandenb-dev svandenb-dev enabled auto-merge (squash) April 2, 2026 15:58
Copy link
Copy Markdown
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.03%. Comparing base (5cbae21) to head (07969b6).
⚠️ Report is 68 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1986      +/-   ##
==========================================
- Coverage   70.20%   70.03%   -0.18%     
==========================================
  Files         261      263       +2     
  Lines       42416    43063     +647     
==========================================
+ Hits        29779    30158     +379     
- Misses      12637    12905     +268     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svandenb-dev svandenb-dev merged commit 53ded43 into main Apr 2, 2026
28 checks passed
@svandenb-dev svandenb-dev deleted the grpc-import-roughness branch April 2, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XML Import - Roughness/Etch

4 participants