Skip to content

Conversation

@ansnfernand
Copy link
Collaborator

Description

Added API import_parts_to_avl()

Issue linked

#390

Checklist:

  • Run unit tests and make sure they all pass
    - Run tests without Sherlock running
    - Run tests with Sherlock GRPC connection
  • Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • Bench test new/modified APIs by using and modifying the code in the example for the API method
  • [] Add new classes to rst files, located at: \doc\source\api
  • [] Generate documentation
  • Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • Check that test code coverage is at least 80% when Sherlock is running
  • Make sure that the title of the pull request follows Commit naming conventions (e.g. feat: adding new PySherlock command)

@ansnfernand ansnfernand added this to the 2026 R1 milestone Aug 1, 2025
@ansnfernand ansnfernand self-assigned this Aug 1, 2025
@ansnfernand ansnfernand added the enhancement New features or code improvements label Aug 1, 2025
@github-actions github-actions bot added testing Anything related to tests documentation Improvements or additions to documentation dependencies Related with project dependencies maintenance Package and maintenance related labels Aug 1, 2025
@ansjmoody ansjmoody linked an issue Aug 1, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 1, 2025

Codecov Report

❌ Patch coverage is 66.12022% with 62 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.46%. Comparing base (2463dc1) to head (fc75d18).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/sherlock/core/types/layer_types.py 66.90% 46 Missing ⚠️
src/ansys/sherlock/core/types/parts_types.py 61.11% 7 Missing ⚠️
src/ansys/sherlock/core/layer.py 40.00% 6 Missing ⚠️
src/ansys/sherlock/core/parts.py 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #617      +/-   ##
==========================================
+ Coverage   61.36%   61.46%   +0.09%     
==========================================
  Files          22       22              
  Lines        5700     5878     +178     
==========================================
+ Hits         3498     3613     +115     
- Misses       2202     2265      +63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ansjmoody ansjmoody self-requested a review August 1, 2025 16:15
@github-actions github-actions bot removed dependencies Related with project dependencies maintenance Package and maintenance related labels Aug 4, 2025
Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>
ansys-pwalters and others added 8 commits August 12, 2025 16:17
Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>
Co-authored-by: Jeff Moody <110494049+ansjmoody@users.noreply.github.com>
Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>
…#624)

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>
@github-actions github-actions bot added dependencies Related with project dependencies maintenance Package and maintenance related labels Aug 26, 2025
@ansjmoody ansjmoody merged commit 2be669e into main Sep 3, 2025
27 checks passed
@ansjmoody ansjmoody deleted the importPartsToAVL branch September 3, 2025 16:41
@ansnfernand ansnfernand mentioned this pull request Sep 8, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Related with project dependencies documentation Improvements or additions to documentation enhancement New features or code improvements maintenance Package and maintenance related testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add API: import_parts_to_avl()

7 participants