Remove fully-rolled-out audio_previews feature flag

[gumclaw]

What

Removes the audio_previews Flipper flag and its dead branches. The flag is globally enabled in production (state=on, boolean=true; prod-state audit request 20260721T025828Z-d0d55a50, gumroad-private#1208) and the gated code has been stable since 2025-04.

Why

Part of the rollout-flag cleanup requested on #6041 / gumroad-private#1208 (Sahil: "Do all A except content mod as kill switch"). Behavior-neutral: the flag is fully on, so every production seller already sees the "Insert audio" description-editor menu item and public audio previews render on all product pages.

Changes

• Presenters: ProductPresenter#edit_props, ProductPresenter::ProductProps#props, and BundlePresenter#bundle_props no longer emit audio_previews_enabled (was Feature.active?(:audio_previews, user) — always true in prod).
• TSX: the audio_previews_enabled prop is removed from Product, ProductEdit/state, BundleEdit/ProductPreview, Bundles/Product/Edit, Bundles/Share/Edit, and ProductEdit/ProductPreview; DescriptionEditor drops the audioPreviewsEnabled param and its upload guard; PublicFileEmbed's "Insert audio" menu item renders unconditionally.
• Specs: removed Feature.activate_user(:audio_previews, …) setups and the audio_previews_enabled prop assertions in the two presenter specs, rich_text_editor_spec, and bundles/edit_spec. No minitest twins (grep -rn audio_previews test/ empty). Repo-wide grep for audio_previews is now zero hits.

QA steps

Flag removal with no user-visible change (flag is 100% enabled in prod, so production behavior is already the post-removal behavior).

1. Confirm grep -rn "audio_previews" app lib config spec test returns nothing.
2. Run the touched specs (see Test results).

Before / After

No adjacent UI change: the description editor's "Insert audio" item and public-file audio players on product pages render identically for all production sellers before and after (the flag was globally on). The spec run below is the reviewable artifact for the behavior-neutral claim.

Test results

• product_presenter/product_props_spec.rb -e "with public files": 1 example, 0 failures
• product_presenter_spec.rb -e "with public files": 1 example, 0 failures
• Full product_presenter_spec.rb + bundle_presenter_spec.rb: 42 examples, 1 failure — :102 fails identically on clean origin/main in this local env (card-charge validation in factory setup); pre-existing, unrelated.
• npx tsc --noEmit: zero errors in touched files (only the pre-existing vite/client typelib note); prettier clean on all 9 touched TS/TSX files.

Post-merge housekeeping (after deploy confirmation): Flipper.remove(:audio_previews) via the audited console, logged against gumroad-private#1208.

---

AI disclosure

🤖 Generated with Claude Fable 5 (Anthropic), running as the Hermes agent "gumclaw" autonomous dev dispatcher. Prompts/instructions: continue the Category A rollout-flag cleanup per gumroad-private#1208 checklist and Sahil's "Do all A except content mod as kill switch" directive; the issue's audit table was used as the spec.

[gumclaw]

Fable-style self-review — PASS (no P1/P2).

Hunt list checked:

• Upload guard removal: DescriptionEditor's if (!audioPreviewsEnabled) return guard is gone, but the very next line still rejects non-audio extensions and the server-side PublicFile path is unchanged — no new upload capability beyond what all prod sellers already have (flag globally on).
• typia contract: audio_previews_enabled removed from every page-props type in the same commit as the presenters, so typia.assert on Product/Bundle pages stays consistent (repo-wide grep: zero remaining references).
• Context consumers: usePublicFilesSettings had exactly two consumers of audioPreviewsEnabled (PublicFileEmbed menuItem + DescriptionEditor onUpload); both updated. The Product-page provider never passed it (only files) — that mismatch existed before and is now resolved by dropping the field from the context type.
• Stale pins: no minitest twins; no negative pins of the flag-off behavior remain in either suite.

Auto-merge armed per gumroad-private#1208 (Category A directive).

[greptile-apps]

Greptile Summary

This PR removes the fully rolled-out audio preview feature flag. The main changes are:

• Removes audio_previews_enabled from presenter payloads and TypeScript types.
• Makes audio insertion available without a frontend feature check.
• Updates product and bundle preview data paths.
• Removes obsolete feature setup and assertions from specs.

Confidence Score: 5/5

This looks safe to merge.

No blocking issues found in the changed code.

T-Rex Logs

What T-Rex did

• Compared the pre-change state to the post-change state and verified that the exact requested search returns no results.
• Identified a blocker that prevented progress and documented it with a runtime blocker log listing Ruby, the Gemfile directive, the required .ruby-version, and a failing bundle check.

_{Ran code and verified through T-Rex}

Important Files Changed

Filename	Overview
app/javascript/components/ProductEdit/ProductTab/DescriptionEditor.tsx	Removes the rollout property and guard while retaining audio validation, upload handling, and cleanup.
app/javascript/components/TiptapExtensions/PublicFileEmbed.tsx	Makes the Insert audio menu item unconditional to match the completed rollout.
app/javascript/components/Product/index.tsx	Removes the obsolete product field and editor-context value.
app/presenters/product_presenter.rb	Removes the obsolete feature state from product edit payloads.
app/presenters/product_presenter/product_props.rb	Removes the obsolete feature state from public product payloads.
app/presenters/bundle_presenter.rb	Removes the obsolete feature state from bundle page payloads.

_{Reviews (1): Last reviewed commit: "Remove fully-rolled-out audio_previews f..." | Re-trigger Greptile}