Remove fully-rolled-out commissions feature flag

[gumclaw]

What

Removes the commissions Flipper flag and its dead branches. The flag is globally enabled in production (state=on, boolean=true; prod-state audit request 20260721T025828Z-d0d55a50, gumroad-private#1208) and the gated code has been stable since 2025-04.

Why

Next Category A flag in the rollout-flag cleanup requested on #6041 / gumroad-private#1208 (Sahil: "Do all A except content mod as kill switch"). Behavior-neutral: the flag is fully on, so every production seller already sees Commission in the service product types and can create commission products via API v2.

Changes

• ProductPresenter.new_page_props: commission is now unconditionally part of service_product_types (was unless Feature.active?(:commissions, current_seller) — the subtraction never ran in prod).
• Api::V2::LinksController#create: drop the flag-off rejection branch ("You do not have access to create commission products.") — unreachable in prod. The real gates remain: eligible_for_service_products? still rejects sellers <30 days old, and unsupported/legacy types are still rejected.
• Specs: the two new_page_props snapshot expectations now include "commission"; the flag-on context folds into unconditional behavior; flag-off contexts (presenter subtraction, API rejection, "no Commission radio button" system spec) deleted as unrepresentable states.

Repo-wide grep for the flag: the only remaining :commissions hits are config/routes.rb resource routes and unrelated prose (features_markdown_generator.rb copy, artwork-and-commissions taxonomy slug) — no Feature/Flipper references left.

QA steps

Flag removal with no user-visible change (flag is 100% enabled in prod, so production behavior is already the post-removal behavior).

1. Confirm grep -rn "Feature.active?(:commissions\|activate.*:commissions" app lib config spec returns nothing.
2. Run the touched specs (see Test results).

Before / After

No adjacent UI change: the "Commission" option on the new-product page and API v2 commission creation behave identically for all production sellers before and after (the flag was globally on). The spec run below is the reviewable artifact for the behavior-neutral claim.

Test results

• spec/presenters/product_presenter_spec.rb -e "new_page_props": 4 examples, 0 failures
• spec/controllers/api/v2/links_controller_spec.rb:200 (whole POST 'create' block): 79 examples, 0 failures
• rubocop on all 5 touched files: no offenses

Part of the flag-audit workstream tracked in gumroad-private#1208. Post-merge housekeeping (deploy-gated Flipper.remove(:commissions)) queued on the tracker.

Co-authored-by: Sahil Lavingia sahil@gumroad.com

[gumclaw]

fable-5 adversarial pre-merge review — verdict: PASS (no P1/P2)

Hunt list: (a) does removing the API-v2 flag check open an auth hole (the #6091 P1 class), (b) any other consumer of the flag or a derived prop, (c) snapshot specs on other CI shards asserting the old service_product_types, (d) does the flag-off system spec deletion lose real coverage.

• (a) The Remove the ai_product_generation feature flag (100% enabled and stable in prod) #6091 implicit-auth-gate trap does not apply here. The removed branch gated a product type, not a privileged side-effect: commission creation still passes through the same create action's real gates — unsupported_types rejection, eligible_for_service_products? (30-day account age, covered by the surviving "rejects service types when seller is not eligible" example), price/currency validation. With the flag globally on, every seller already had this exact access; no request can now reach code it couldn't reach yesterday.
• (b) Repo-wide grep for :commissions post-change: only config/routes.rb resource routes (the Commission model's own endpoints, unrelated to the flag) and prose strings (features_markdown_generator.rb, the artwork-and-commissions taxonomy slug). No commissions_enabled/commissionsEnabled prop exists anywhere (this flag never crossed into TS), so no FeatureFlags.tsx chain to unwind.
• (c) grep -rln service_product_types spec/ → only product_presenter_spec.rb, already updated. No distant snapshot-spec flip risk (the Remove churn_analytics_enabled feature flag (100% enabled and stable in prod) #6066 CI class).
• (d) The deleted flag-off contexts pinned states unrepresentable after removal (flag-off presenter subtraction, API rejection message, missing radio button). The flag-on system specs survive renamed as "commission products" — the end-to-end create flow and the ineligible-seller tooltip remain covered.
• Specs: presenter new_page_props 4/4, whole API v2 POST 'create' block 79/79, rubocop clean on all 5 files.

Behavior-neutral by construction (state=on bool=true, no partial gates, audit 20260721T025828Z-d0d55a50). Arming auto-merge.

[greptile-apps]

Greptile Summary

This PR removes the fully rolled-out commissions feature flag. The main changes are:

• Makes Commission an unconditional service product type.
• Removes the API v2 flag-off rejection branch.
• Deletes obsolete flag-state tests and updates presenter expectations.

Confidence Score: 5/5

This looks safe to merge.

No blocking issues found in the changed code. Ineligible sellers still cannot select or create service products. Existing API authorization and model validations remain unchanged.

T-Rex Logs

What T-Rex did

• Before-state, the scoped parent-revision search found three references in the links controller, product presenter, and product creation spec.
• After-state, the current-tree search produced no matches and rg exited with status 1, indicating no matches were found.
• Two focused RSpec attempts were run, but both failed because Bundler could not find the rspec command, exiting with 127.
• Bundle check failed with exit 18 and Ruby 3.1.2 does not satisfy the Gemfile requirement, explaining the environment incompatibility.

_{Ran code and verified through T-Rex}

Important Files Changed

Filename	Overview
app/controllers/api/v2/links_controller.rb	Removes the obsolete commission flag check while retaining API authorization and model-level eligibility validation.
app/presenters/product_presenter.rb	Always includes Commission among service product types; the frontend separately disables service products for ineligible sellers.
spec/controllers/api/v2/links_controller_spec.rb	Removes the obsolete flag-off API rejection example.
spec/presenters/product_presenter_spec.rb	Updates presenter expectations for unconditional Commission availability.
spec/requests/products/creation_spec.rb	Removes the obsolete flag-off UI scenario while retaining seller eligibility coverage.

_{Reviews (1): Last reviewed commit: "Remove fully-enabled commissions feature..." | Re-trigger Greptile}