Remove obsolete comments and add minor improvements to OfflineIterator#2421
Merged
DomGarguilo merged 2 commits intoapache:mainfrom Jan 20, 2022
Merged
Remove obsolete comments and add minor improvements to OfflineIterator#2421DomGarguilo merged 2 commits intoapache:mainfrom
DomGarguilo merged 2 commits intoapache:mainfrom
Conversation
ctubbsii
approved these changes
Jan 19, 2022
core/src/main/java/org/apache/accumulo/core/clientImpl/OfflineIterator.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2413
#2413 was created to address the possibility of two things:
It seems that neither of these should be done.
The original Jira ticket referenced shared code between OfflineIterator and Tablet, but since then, the code has moved to ScanDataSource and changed significantly meaning extracting commonalities between the two may not be worth it/feasible.
The second point about closing the resources proves to cause error. If the readers or files are closed, the iterator fails to read the intended data therefore I think its best if they are not closed.
The changes made in this PR: