Use constants for tables instead of string literals#3089
Merged
ctubbsii merged 1 commit intoapache:mainfrom Nov 22, 2022
Merged
Use constants for tables instead of string literals#3089ctubbsii merged 1 commit intoapache:mainfrom
ctubbsii merged 1 commit intoapache:mainfrom
Conversation
Use existing constants for referencing the table names and IDs for built-in tables in a few places that previously used hard-coded string literals. These aren't likely to change, but it makes it easier to find references of these built-ins when they use the constant, and it's easier to avoid typos.
EdColeman
approved these changes
Nov 21, 2022
DomGarguilo
approved these changes
Nov 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use existing constants for referencing the table names and IDs for built-in tables in a few places that previously used hard-coded string literals. These aren't likely to change, but it makes it easier to find references of these built-ins when they use the constant, and it's easier to avoid typos.
I found these while working on #3080. They are very trivial, but nice to have.