Remove deprecated CompactionStrategy for version 3.0#3112
Merged
Conversation
This removes all of the old CompactionStrategy related classes,tests, and properties. This closes apache#3111
Contributor
Author
|
I just kicked off a full IT build for this PR and will report back the results when done. |
Contributor
Author
|
Full IT build finished and passed. |
Contributor
Author
|
@keith-turner - Thanks for the feedback, I went through the comments today and I will start addressing them tomorrow. |
Contributor
Author
|
@keith-turner - Ok I think I addressed all of the items in your feedback, take a look again when you get a chance and see what you think. I will kick off another full IT as well just to verify everything. |
keith-turner
approved these changes
Jan 9, 2023
keith-turner
left a comment
keith-turner
left a comment
Contributor
There was a problem hiding this comment.
Looks great @cshannon
Contributor
Author
Thanks, I'll go ahead and merge this in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes all of the old CompactionStrategy related classes,tests, and properties.
This closes #3111