Replace UtilWaitThread.sleepUninterruptibly with guava equivalent

[DomGarguilo]

UtilWaitThread.sleepUninterruptibly was copied from guavas Uninterruptibles.sleepUninterruptibly when it was still tagged as beta. With the version of guava we are using, Uninterruptibles.sleepUninterruptibly is no longer tagged as beta. This PR removes the copied method and uses guava directly.

[EdColeman]

Are there any newer java 11 added options instead of guava?

[dlmarion]

I thought we were trying to remove Guava dependencies in general.

[cshannon]

It definitely makes sense to me to first try and use native Java code/utilities when possible, such as lambdas instead of Guavas iterable utilities. But if something doesn't exist I think it would be fine to use the utility in Guava or something like a Commons library so we don't have to re-invent the wheel, assuming the plan isn't to actually remove the dependency entirely at some point.

[DomGarguilo]

It definitely makes sense to me to first try and use native Java code/utilities when possible, such as lambdas instead of Guavas iterable utilities. But if something doesn't exist I think it would be fine to use the utility in Guava or something like a Commons library so we don't have to re-invent the wheel, assuming the plan isn't to actually remove the dependency entirely at some point.

I agree with these points.

@EdColeman I don't know of/can't find any native java replacements for this. That's not to say one does not exist but I haven't been able to find anything yet.

@dlmarion As for removing guava, I am not sure either. My understanding is that when possible, we should avoid using guava for a built in equivalent, not sure if we have plans to completely remove it as a dependency though.

[ctubbsii]

I don't think we have a plan to remove Guava entirely. We have tried to avoid the problematic beta methods, certainly. It's also good to reduce our dependency on any external library, Guava is not an exception to that. The modernizer-maven-plugin helps identify some of those things. For non-beta methods that we expect to be stable, and for which we expect a minimum Guava version to be required, I don't think it's a problem to use the utility that Guava provides. We'll need to fix the dependency check first before this is merged (just add the guava dependency explicitly to the modules that didn't have it as a compile time dependency before, but now do).

[EdColeman]

Is the build failure transient - or is there a dependency that needs to be adjusted?

[DomGarguilo]

Is the build failure transient - or is there a dependency that needs to be adjusted?

No, it isn't transient. The build is passing from a "used undeclared" dependency warning. Looking into solutions now - should have a fix up soon.

[DomGarguilo]

Is the build failure transient - or is there a dependency that needs to be adjusted?

Fixed in ac427d0 @EdColeman

[cshannon]

This seems fine to me now that the checks are passing unless anyone else has any comments or concerns.