Timeout value addd to wait for scans servers#4638
Merged
dlmarion merged 6 commits intoapache:elasticityfrom Jun 18, 2024
Merged
Timeout value addd to wait for scans servers#4638dlmarion merged 6 commits intoapache:elasticityfrom
dlmarion merged 6 commits intoapache:elasticityfrom
Conversation
…de it a timeout value
keith-turner
reviewed
Jun 5, 2024
core/src/main/java/org/apache/accumulo/core/spi/scan/ConfigurableScanServerSelector.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/accumulo/core/spi/scan/ConfigurableScanServerSelector.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/accumulo/core/spi/scan/ConfigurableScanServerSelector.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/accumulo/core/spi/scan/ConfigurableScanServerSelector.java
Show resolved
Hide resolved
dlmarion
reviewed
Jun 6, 2024
core/src/test/java/org/apache/accumulo/core/spi/scan/ConfigurableScanServerSelectorTest.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/accumulo/core/spi/scan/ConfigurableScanServerSelector.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/accumulo/core/spi/scan/ConfigurableScanServerSelector.java
Outdated
Show resolved
Hide resolved
dlmarion
reviewed
Jun 12, 2024
core/src/main/java/org/apache/accumulo/core/spi/scan/ConfigurableScanServerSelector.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/apache/accumulo/core/spi/scan/ConfigurableScanServerSelectorTest.java
Outdated
Show resolved
Hide resolved
keith-turner
approved these changes
Jun 12, 2024
ddanielr
reviewed
Jun 12, 2024
Contributor
ddanielr
left a comment
ddanielr
left a comment
There was a problem hiding this comment.
There's some minor documentation updates that are needed.
Otherwise looks good.
core/src/main/java/org/apache/accumulo/core/spi/scan/ConfigurableScanServerSelector.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/accumulo/core/spi/scan/ConfigurableScanServerSelector.java
Outdated
Show resolved
Hide resolved
dlmarion
reviewed
Jun 14, 2024
core/src/main/java/org/apache/accumulo/core/spi/scan/ConfigurableScanServerSelector.java
Outdated
Show resolved
Hide resolved
| * <li>"ms" for milliseconds</li> | ||
| * </ul> | ||
| * If duration is not specified this setting defaults to 0s, and will disable the wait for scan | ||
| * servers. When set to a large value, the selector will effectively wait for scan servers to become |
Contributor
There was a problem hiding this comment.
Suggested change
| * servers. When set to a large value, the selector will effectively wait for scan servers to become | |
| * servers and will fall back to tablet servers immediately. When set to a large value, the selector will effectively wait for scan servers to become |
Contributor
|
I think this is good to merge, just a few minor comments on the javadoc. |
Contributor
|
@ArbaazKhan1 - if you can merge address the latest comments, then I should be able to merge this in. |
dlmarion
approved these changes
Jun 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue#4532
Changed
enableTabletServerFallbacktotimeToWaitForScanServersand made it a timeout value. Please take a look at the class description and see if the explanationtimeToWaitForScanServersis sufficient enough. This update will need to be added into 2.1 as well.