Back ported Timeout value to 2.1#4671
Merged
ddanielr merged 2 commits intoapache:2.1from Jun 18, 2024
Merged
Conversation
ddanielr
requested changes
Jun 18, 2024
Contributor
ddanielr
left a comment
ddanielr
left a comment
There was a problem hiding this comment.
ScanServerIT_NoServers.java is currently not passing when run locally.
I added a comment for what I believe is causing the problem.
core/src/main/java/org/apache/accumulo/core/spi/scan/ConfigurableScanServerSelector.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/accumulo/core/spi/scan/ConfigurableScanServerSelector.java
Outdated
Show resolved
Hide resolved
ddanielr
approved these changes
Jun 18, 2024
ddanielr
added a commit
to ddanielr/accumulo
that referenced
this pull request
Jun 18, 2024
* Adding no-op merge for apache#4671
ddanielr
added a commit
to ddanielr/accumulo
that referenced
this pull request
Jun 18, 2024
* Noop merge for apache#4671 via merge strategy `ort -Xours`
keith-turner
added a commit
to keith-turner/accumulo
that referenced
this pull request
Aug 20, 2024
By default when using eventual scans and there are no scan servers present then the scan will fall back to tablet servers. This could be very suprising and disruptive when tablet servers do not have much resources allocated for scanning and scan servers do. In the case were scan servers are temporarily down it could cause a thundering herd that overwhelms tablet servers. This commit changes the default behavior to not fall back to tablet servers. This change is targeting 3.1 in order to avoid changing default behavior in 2.1.X. The capability to not fall back to tablet servers was introduced in 2.1.3 via apache#4671 with a default behavior to fallback.
keith-turner
added a commit
that referenced
this pull request
Aug 27, 2024
…4814) By default when using eventual scans and there are no scan servers present then the scan will fall back to tablet servers. This could be very surprising and disruptive when tablet servers do not have much resources allocated for scanning and scan servers do. In the case were scan servers are temporarily down it could cause a thundering herd that overwhelms tablet servers. This commit changes the default behavior to not fall back to tablet servers. This change is targeting 3.1 in order to avoid changing default behavior in 2.1.X. The capability to not fall back to tablet servers was introduced in 2.1.3 via #4671 with a default behavior to fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is inline with pull #4638 , where it is adding the client option to wait for scan servers