Provide a better initial size for collections if possible#6464
Merged
Conversation
ddanielr
reviewed
Jul 8, 2026
| final Map<String,FileInfo> files; | ||
|
|
||
| public Files(Collection<FileInfo> files) { | ||
| this.files = new HashMap<>(files.size(), 1.0f); |
Contributor
There was a problem hiding this comment.
Why the change from the default 0.75 load factor to 1.0?
Member
There was a problem hiding this comment.
I think the 1.0 load factor prevents resizing until you try to exceed the current size. So this avoids an unnecessary resize as we're filling it up with a known quantity.
Contributor
Author
There was a problem hiding this comment.
Exactly. If we know the size before-hand, then we can set the collection size appropriately so that it won't resize.
ctubbsii
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.