Update to the latest log4j and spotbugs versions#6486
Open
ddanielr wants to merge 10 commits into
Open
Conversation
Bumps versions and fixes deprecated builder pattern
dlmarion
approved these changes
Jul 21, 2026
ctubbsii
reviewed
Jul 22, 2026
ctubbsii
left a comment
ctubbsii
left a comment
Member
There was a problem hiding this comment.
The build is still failing. I think it's probably okay to suppress these in 2.1, but in main, we should work to remove the problems spotbugs found, because we do a lot less static stuff in the main branch now, and we can probably do better with regards to these checks there.
Added private locks for methods that were synchronized to fix spotbugs findings
Runnable requires a public run() method so these can't be fixed
Fixed these spotbug findings
The intent of this code is not clear. This may not be the correct way to do this but will review it at the PR stage.
dlmarion
reviewed
Jul 22, 2026
dlmarion
left a comment
dlmarion
left a comment
Contributor
There was a problem hiding this comment.
I'm a little confused why we are making so many changes if we are also excluding these spotbugs issues.
| ThreadPools.watchCriticalScheduledTask(context.getScheduledExecutor().scheduleWithFixedDelay( | ||
| new CompactionWatcher(context.getConfiguration()), 10000, 10000, TimeUnit.MILLISECONDS)); | ||
| watching = true; | ||
| public static void startWatching(ServerContext context) { |
Contributor
There was a problem hiding this comment.
Does the exclusion not cover this case? Just curious why we are fixing some of these but also have the exclusion.
| // remove old settings from zookeeper first, if any | ||
| ZooReaderWriter zoo = context.getZooReaderWriter(); | ||
| synchronized (zooCache) { | ||
| synchronized (zooCacheLock) { |
Contributor
There was a problem hiding this comment.
Why did this have to change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps versions and fixes deprecated builder pattern