Allow users to set hdfs_namenode_principal in HDFSHook config - #1112
Conversation
|
Please review @mistercrunch @bolkedebruin |
|
@garthcn this won't be enough at it is dependent on a snakebite release. Is that new release available yet? If so then increase the requirements in setup.py. If not we have to wait :-) |
|
@bolkedebruin And in https://github.com/airbnb/airflow/blob/master/setup.py#L56, it has |
|
But it won't install a new version. 2.7.8 is now required for existing installations. So it does need to be updated. |
|
@bolkedebruin that makes sense. i just bumped the version in |
There was a problem hiding this comment.
None is redundant/implicit here, no need to write it
|
@artwr, can you run our local tests against this for a final blessing?! Feel free to merge once you confirm it works. |
|
@mistercrunch @artwr any update on this? |
|
Sorry, I am a little tied up at the moment, but I promise I will get to it asap... |
|
@artwr no worries. thanks for working on this :) |
|
Ping :) @artwr |
|
@garthcn can you rebase? i will merge then |
snakebite library just added the support to specify hdfs_namenode_principal for Kerberos auth method, and this PR allows users to pass in this config from HDFSHook Also bump the version of snakebite
|
@bolkedebruin just rebased to |
Allow users to set hdfs_namenode_principal in HDFSHook config
6 participants
snakebitelibrary just added the support to specifyhdfs_namenode_principalfor Kerberos auth method, and this PR allows users to pass in this config fromHDFSHook