In DagBag set read_dags_from_db from config#13521
Closed
john-jac wants to merge 1 commit intoapache:masterfrom
Closed
In DagBag set read_dags_from_db from config#13521john-jac wants to merge 1 commit intoapache:masterfrom
john-jac wants to merge 1 commit intoapache:masterfrom
Conversation
Update dagbag.py read_dags_from_db __ini__ parameter to set from config rather than default to False. This will allow CLI backfill to work from stored DAGs and also matches the read_dags_from_db behavior to match that of the other DagBag input parameters.
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
kaxil
reviewed
Jan 7, 2021
| include_smart_sensor: bool = conf.getboolean('smart_sensor', 'USE_SMART_SENSOR'), | ||
| safe_mode: bool = conf.getboolean('core', 'DAG_DISCOVERY_SAFE_MODE'), | ||
| read_dags_from_db: bool = False, | ||
| read_dags_from_db: bool = conf.getboolean('core', 'STORE_DAG_CODE'), |
Member
There was a problem hiding this comment.
Hey John as mentioned on Slack, this won't be the correct fix,
read_dags_from_db decides if it should read the DAGs from DB (Serialized Dags from serialized_dag table). The conf.getboolean('core', 'STORE_DAG_CODE') config is only used in Webserver to show the Code (as plain strings) from the dag_code table.
Contributor
Author
|
Not the correct solution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update dagbag.py read_dags_from_db ini parameter to set from config rather than default to False. This will allow CLI backfill to work from stored DAGs and also matches the read_dags_from_db behavior to match that of the other DagBag input parameters.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.