Skip to content

In DagBag set read_dags_from_db from config #13521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
john-jac wants to merge 1 commit into from
Closed

In DagBag set read_dags_from_db from config #13521

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airflow/models/dagbag.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def __init__(
include_examples: bool = conf.getboolean('core', 'LOAD_EXAMPLES'),
include_smart_sensor: bool = conf.getboolean('smart_sensor', 'USE_SMART_SENSOR'),
safe_mode: bool = conf.getboolean('core', 'DAG_DISCOVERY_SAFE_MODE'),
read_dags_from_db: bool = False,
read_dags_from_db: bool = conf.getboolean('core', 'STORE_DAG_CODE'),
Copy link
Member

@kaxil kaxil Jan 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey John as mentioned on Slack, this won't be the correct fix,

read_dags_from_db decides if it should read the DAGs from DB (Serialized Dags from serialized_dag table). The conf.getboolean('core', 'STORE_DAG_CODE') config is only used in Webserver to show the Code (as plain strings) from the dag_code table.

store_serialized_dags: Optional[bool] = None,
):
# Avoid circular import
Expand Down