Skip to content

Conversation

@SamWheating
Copy link
Contributor

@SamWheating SamWheating commented Jan 7, 2021

A user on Slack pointed out that the docs URL returned in a 403 API response was broken.

According to the user's report, the 403 response looked like this:

{
    "detail": null,
    "status": 403,
    "title": "Forbidden",
    "type": "https://airflow.apache.org/docs/2.0.0/stable-rest-api-ref.html#section/Errors/PermissionDenied"
}

A quick look into the source and it appears that this reference does in fact point to a nonexistent page.

Before:
https://airflow.apache.org/docs/2.0.0/stable-rest-api-ref.html#section/Errors/PermissionDenied

After:
https://airflow.apache.org/docs/apache-airflow/2.0.0/stable-rest-api-ref.html#section/Errors/PermissionDenied


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Jan 7, 2021
@SamWheating
Copy link
Contributor Author

SamWheating commented Jan 7, 2021

I also found this link in the deprecation headers for the experimental API which appears to be broken.

doc_url = get_docs_url("stable-rest-api/migration.html")

However, I don't know what the correct link should be here. Thoughts?

update: It looks like its a reference to this page, which have since been removed.

@mik-laj
Copy link
Member

mik-laj commented Jan 7, 2021

However, I don't know what the correct link should be here. Thoughts?

https://airflow.apache.org/docs/apache-airflow/stable/upgrading-to-2.html#migration-guide-from-experimental-api-to-stable-api-v1

Copy link
Contributor

@ryanahamilton ryanahamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this PR earlier, but I believe most of these issues were resolved in #13250 and #14080. The issue in endpoints.py still persists, so you could go ahead with that after rebasing.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Mar 30, 2021
@ryanahamilton
Copy link
Contributor

@SamWheating if you don't mind rebasing this (and then pinging me), I can get it merged in.

@SamWheating SamWheating requested a review from ashb as a code owner March 30, 2021 14:36
@SamWheating
Copy link
Contributor Author

@SamWheating if you don't mind rebasing this (and then pinging me), I can get it merged in.

@ryanahamilton done ✅

@ryanahamilton ryanahamilton removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Mar 30, 2021
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Mar 30, 2021
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@ryanahamilton ryanahamilton merged commit 390015d into apache:master Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API okay to merge It's ok to merge this PR as it does not require more tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants