-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Fixing broken documentation links in API exceptions #13547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I also found this link in the deprecation headers for the experimental API which appears to be broken.
However, I don't know what the correct link should be here. Thoughts? update: It looks like its a reference to this page, which have since been removed. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5bea8a4 to
bed03d3
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
|
@SamWheating if you don't mind rebasing this (and then pinging me), I can get it merged in. |
bed03d3 to
b77d897
Compare
@ryanahamilton done ✅ |
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
A user on Slack pointed out that the docs URL returned in a 403 API response was broken.
According to the user's report, the 403 response looked like this:
A quick look into the source and it appears that this reference does in fact point to a nonexistent page.
Before:
https://airflow.apache.org/docs/2.0.0/stable-rest-api-ref.html#section/Errors/PermissionDenied
After:
https://airflow.apache.org/docs/apache-airflow/2.0.0/stable-rest-api-ref.html#section/Errors/PermissionDenied
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.