Skip to content

Conversation

@monti-python
Copy link
Contributor

closes: #15636

List all terminal blobs
@boring-cyborg
Copy link

boring-cyborg bot commented May 3, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@monti-python monti-python changed the title Update wasb.py Fix WasbHook.delete_file broken when using prefix May 3, 2021
@monti-python monti-python requested a review from ephraimbuddy May 4, 2021 08:26
monti-python and others added 2 commits May 4, 2021 10:45
Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
@github-actions
Copy link

github-actions bot commented May 4, 2021

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label May 4, 2021
@ephraimbuddy ephraimbuddy merged commit b1bd594 into apache:master May 4, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented May 4, 2021

Awesome work, congrats on your first merged pull request!

@ephraimbuddy
Copy link
Contributor

Congrats @monti-python 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:microsoft-azure Azure-related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WasbHook does not delete blobs with slash characters in prefix mode

2 participants