Update Watchtower version to 1.0.6#16469
Merged
potiuk merged 1 commit intoapache:mainfrom Jun 18, 2021
Merged
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
207fd82 to
508a1f8
Compare
Member
|
This one will fail likely . I looked at this and some recent change made "setup.py' changes do not work the way they should. Fix is coming #16470 |
Currently a pre 1.0 version of Watchtower is being used. There have been many bug fixes and improvements since this version.
508a1f8 to
5a3aaf1
Compare
Member
|
🤞 |
potiuk
approved these changes
Jun 18, 2021
|
Awesome work, congrats on your first merged pull request! |
potiuk
pushed a commit
to potiuk/airflow
that referenced
this pull request
Jun 22, 2021
Currently a pre 1.0 version of Watchtower is being used. There have been many bug fixes and improvements since this version. (cherry picked from commit cf404b4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently a pre 1.0 version of Watchtower is being used. There have been
many bug fixes and improvements since this version (the changelog can be found here).
This change updates Airflow's specified version in setup.py.
I have ran the following commands to test this locally:
./breeze generate-constraints --generate-constraints-mode source-providers./scripts/ci/testing/ci_run_airflow_testing.shI believe this is the only line that needs to be changed for a dependency upgrade (see discussion I started on the community slack) but please correct me if I'm wrong here.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.