Skip to content

Update Watchtower version to 1.0.6#16469

Merged
potiuk merged 1 commit intoapache:mainfrom
o-nikolas:watchtower_update
Jun 18, 2021
Merged

Update Watchtower version to 1.0.6#16469
potiuk merged 1 commit intoapache:mainfrom
o-nikolas:watchtower_update

Conversation

@o-nikolas
Copy link
Copy Markdown
Contributor

Currently a pre 1.0 version of Watchtower is being used. There have been
many bug fixes and improvements since this version (the changelog can be found here).

This change updates Airflow's specified version in setup.py.

I have ran the following commands to test this locally:

./breeze generate-constraints --generate-constraints-mode source-providers

./scripts/ci/testing/ci_run_airflow_testing.sh

I believe this is the only line that needs to be changed for a dependency upgrade (see discussion I started on the community slack) but please correct me if I'm wrong here.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg
Copy link
Copy Markdown

boring-cyborg bot commented Jun 15, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk
Copy link
Copy Markdown
Member

potiuk commented Jun 15, 2021

This one will fail likely . I looked at this and some recent change made "setup.py' changes do not work the way they should. Fix is coming #16470

Currently a pre 1.0 version of Watchtower is being used. There have been
many bug fixes and improvements since this version.
@o-nikolas o-nikolas force-pushed the watchtower_update branch from 508a1f8 to 5a3aaf1 Compare June 17, 2021 19:04
@potiuk
Copy link
Copy Markdown
Member

potiuk commented Jun 17, 2021

🤞

@potiuk potiuk merged commit cf404b4 into apache:main Jun 18, 2021
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg bot commented Jun 18, 2021

Awesome work, congrats on your first merged pull request!

potiuk pushed a commit to potiuk/airflow that referenced this pull request Jun 22, 2021
Currently a pre 1.0 version of Watchtower is being used. There have been
many bug fixes and improvements since this version.

(cherry picked from commit cf404b4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants