Checks-out missing commits on selective checks#16470
Merged
kaxil merged 1 commit intoapache:mainfrom Jun 17, 2021
Merged
Conversation
Member
Author
|
This one failed #16469 because the PR commits were missing https://github.com/apache/airflow/runs/2834014923?check_suite_focus=true#step:4:584 |
potiuk
force-pushed
the
fix-missing-commits-on-selective-checks
branch
from
74a30ed to
2b32989
Compare
Recent improvement of the build images to use pull_request_target removed by accident fetching of the PR commits which makes it impossible to determine which files has changed in PR in the PR build image workflow. This commit brings it back.
potiuk
force-pushed
the
fix-missing-commits-on-selective-checks
branch
from
2b32989 to
da31761
Compare
Contributor
|
Is the |
kaxil
approved these changes
Jun 16, 2021
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
Member
Yup |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 22, 2021
Recent improvement of the build images to use pull_request_target removed by accident fetching of the PR commits which makes it impossible to determine which files has changed in PR in the PR build image workflow. This commit brings it back. (cherry picked from commit b11166b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent improvement of the build images to use pull_request_target
removed by accident fetching of the PR commits which makes it
impossible to determine which files has changed in PR in the
PR build image workflow.
This commit brings it back.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.