Fixing tests that leave traces (users)#18653
Closed
khalidmammadov wants to merge 15 commits intoapache:mainfrom
Closed
Fixing tests that leave traces (users)#18653khalidmammadov wants to merge 15 commits intoapache:mainfrom
khalidmammadov wants to merge 15 commits intoapache:mainfrom
Conversation
Contributor
Author
|
@potiuk can you please take a look? |
Without adding the AWS region to the URL, SQLAlchemy engines created by Airflow can't write dataframes to snowflake using pd_writer. This PR fixes this.
The UI breaks when a search field sends a null datetime. This fixes it
* Remove sleep from retry delay test * Change to use freezegun * Approximate smallest timedelta without numpy * Use pre-defined smallest timedelta It turns out `datetime.datetime.resolution` is already defined as the smallest possible timedelta (one microsecond). Attempting to create a timedelta with microseconds in the interval (0.5, 1) simply results in microseconds being rounded up to 1.
This pattern of having a local table of contents seems to have been cargo-culted to all of the providers, and other pages, but our Sphinx theme already has the lage contents on the right hand side -- this is just leading to duplication. (Not to mention that for the majority of cases the page is so short that you can easily see everytine at once anyway.) I have left it in a few places -- for instance the main configurations-ref.rst I have kept it.
…pache#18655) We currently show a nice error message when the trigger button is clicked but clicking on trigger DAG w/conf for a dag that doesn't exist anymore, takes us to enter configuration. When you eventually trigger, you get error messages. This PR fixes it
* Support all Unix wildcards in S3KeySensor This addresses issue 15538 by expanding the regular expression to include all possible wildcard input to fnmatch * Added tests for s3 and s3_key
Member
|
Very good idea - it needs somet static check fixes after rebase, but I think it is a step in the right direction to get rid of the side-effects between tests. Can you please rebase and fix the tests @khalidmammadov ? |
Contributor
Author
|
Thanks @potiuk, will do rebase and fixes. |
…alidmammadov/airflow into fix_test_user_creation_traces
khalidmammadov
requested review from
ashb,
bbovenzi,
jedcunningham,
kaxil,
mik-laj,
potiuk,
ryanahamilton,
turbaszek and
vikramkoka
as code owners
Contributor
Author
|
Closing as it brought other changes after rebase... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are loads of test that leave traces e.g. don't delete users for example once their tests are complete.
This PR adds a new function and makes use of them in the test suite.
If PR accepted, I will file some more similar PR's to fix remaining test cases. This is deliberately scoped to keep changes to minimum.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.