Fix Task Duration Calculation & Display

[aschoe21]

closes: #23169
Prevent moment from truncating the result of diff to zero decimal places

As moment.diff has the default behavior of truncating the decimal places of diff results (i.e. rounding down to the nearest integer), when the duration of a task run is less than a full second moment rounds the duration down to 0. This behavior results in the task duration rendering as empty/null rather than as the correct task run duration.

Moment's diff function accepts a third, optional boolean argument that dictates its result truncation behavior. By default this value is false which leads to the unwanted behavior described above. Setting this argument to true when calling diff will allow the result to exist as a decimal, fixing the situation where task run duration is rounded down to 0 seconds.

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

• Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@airflow.apache.org
  Slack: https://s.apache.org/airflow-slack

[frankcash]

hi @aschoe21 could you include a screenshot of the functionality working as well?

[aschoe21]

hi @aschoe21 could you include a screenshot of the functionality working as well?

Sure, here's a screenshot of the tooltip showing a task completing in 0.105Sec

[uranusjr]

Would the decimal places always show, even when the duration is long? Ideally I’d only want them when the duration is <1 and not if it’s e.g. 105.378 seconds.

[bbovenzi]

Would the decimal places always show, even when the duration is long? Ideally I’d only want them when the duration is <1 and not if it’s e.g. 105.378 seconds.

Yes, and this also breaks down when duration is better shown as minutes, hours or even days. Overall, how we display durations in the UI is inconsistent and we should consolidate down to one format. I was playing around with that here: https://github.com/apache/airflow/pull/22996/files

What do you think of choosing the most important unit and then limiting to just 1-2 decimal places:

[ashb]

I think if it's in to minutes or hours then 1h58m is better 1.98h

[bbovenzi]

Let's update convertSecondsToHumanReadable in main.js:

• Only show decimal if seconds is less than 1
• If decimal is also 0, then lets return <1ms
• Switch Hours -> h, Min -> m, Sec -> s

I think with those changes this should be good to merge. Then we can update the rest of the UI and webserver to make sure duration is always displayed consistently.

[eladkal]

@aschoe21 are you still working on this PR?

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.