Skip to content

Fix Task Duration Calculation & Display #23173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aschoe21 wants to merge 2 commits into from
Closed

Fix Task Duration Calculation & Display #23173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5731e7c
Fixed calls to moment#diff
aschoe21 Apr 22, 2022
da586f6
Added newsfragment for task_duration_display_fix
aschoe21 Apr 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airflow/www/static/js/graph.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,7 @@ function groupTooltip(node, tis) {
}
});

const groupDuration = convertSecsToHumanReadable(moment(maxEnd).diff(minStart, 'second'));
const groupDuration = convertSecsToHumanReadable(moment(maxEnd).diff(minStart, 'second', true));
const tooltipText = node.tooltip ? `<p>${node.tooltip}</p>` : '';

let tt = `
Expand Down
4 changes: 2 additions & 2 deletions airflow/www/static/js/task_instances.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,11 @@ export default function tiTooltip(ti, { includeTryNumber = false } = {}) {
// Calculate duration on the fly if task instance is still running
if (ti.state === 'running') {
const startDate = ti.start_date instanceof moment ? ti.start_date : moment(ti.start_date);
ti.duration = moment().diff(startDate, 'second');
ti.duration = moment().diff(startDate, 'second', true);
} else if (!ti.duration && ti.end_date) {
const startDate = ti.start_date instanceof moment ? ti.start_date : moment(ti.start_date);
const endDate = ti.end_date instanceof moment ? ti.end_date : moment(ti.end_date);
ti.duration = moment(endDate).diff(startDate, 'second');
ti.duration = moment(endDate).diff(startDate, 'second', true);
}

tt += `Duration: ${escapeHtml(convertSecsToHumanReadable(ti.duration))}<br>`;
Expand Down
1 change: 1 addition & 0 deletions newsfragments/23173.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed a bug where task run duration would not be displayed properly when duration is less than 1 second