Retain on_failure_fail_dagrun attr when other task attrs are overriden#31678
Merged
ephraimbuddy merged 1 commit intoapache:mainfrom Jun 2, 2023
Merged
Retain on_failure_fail_dagrun attr when other task attrs are overriden#31678ephraimbuddy merged 1 commit intoapache:mainfrom
ephraimbuddy merged 1 commit intoapache:mainfrom
Conversation
When on_failure_fail_dagrun is True on a task and we override other attributes of a task using task.override, we should still retain the value of on_failure_fail_dagrun. This needs special treatment since it's not original task param.
uranusjr
approved these changes
Jun 2, 2023
Contributor
|
moved to 2.7.0 milestone as this PR is part of AIP-52 |
jedcunningham
added
the
changelog:skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When on_failure_fail_dagrun is True on a task and we override other attributes of a task using task.override, we should still retain the value of on_failure_fail_dagrun. This needs special treatment since it's not original task param.