Skip to content

Retain on_failure_fail_dagrun attr when other task attrs are overriden #31678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ephraimbuddy merged 1 commit into from
Jun 2, 2023
Merged

Retain on_failure_fail_dagrun attr when other task attrs are overriden #31678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions airflow/decorators/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,6 +488,7 @@ def override(self, **kwargs: Any) -> _TaskDecorator[FParams, FReturn, OperatorSu
result = attr.evolve(self, kwargs={**self.kwargs, **kwargs})
setattr(result, "is_setup", self.is_setup)
setattr(result, "is_teardown", self.is_teardown)
setattr(result, "on_failure_fail_dagrun", self.on_failure_fail_dagrun)
return result


Expand Down
12 changes: 12 additions & 0 deletions tests/decorators/test_setup_teardown.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,18 @@ def mytask():
assert teardown_task.is_teardown
assert teardown_task.on_failure_fail_dagrun

def test_retain_on_failure_fail_dagrun_when_other_attrs_are_overriden(self, dag_maker):
@teardown(on_failure_fail_dagrun=True)
def mytask():
print("I am a teardown task")

with dag_maker() as dag:
mytask.override(task_id="mytask2")()
assert len(dag.task_group.children) == 1
teardown_task = dag.task_group.children["mytask2"]
assert teardown_task.is_teardown
assert teardown_task.on_failure_fail_dagrun

def test_setup_teardown_mixed_up_in_a_dag(self, dag_maker):
@setup
def setuptask():
Expand Down