Add random suffix to coverage reports#33605
Merged
potiuk merged 2 commits intoapache:mainfrom Aug 22, 2023
Merged
Conversation
Taragolis
force-pushed
the
add-random-suffix-to-coverage-reports
branch
2 times, most recently
from
56c8764 to
d562e62
Compare
potiuk
reviewed
Aug 22, 2023
Taragolis
force-pushed
the
add-random-suffix-to-coverage-reports
branch
from
d562e62 to
06c1f0d
Compare
Taragolis
commented
Aug 22, 2023
| PYTHON_MAJOR_MINOR_VERSION: "${{needs.build-info.outputs.default-python-version}}" | ||
| JOB_ID: "helm-tests" | ||
| COVERAGE: "${{needs.build-info.outputs.run-coverage}}" | ||
| COVERAGE: "false" # We do not need to run coverage on Helm tests |
Contributor
Author
There was a problem hiding this comment.
We already have --no-cov option for Helm, this change just in case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we generate name of coverage.py output files we use only test type + backend, however for providers we run it multiple times, and we could overwrite test results, I guess that the reason why coverage dropped by around 10-15% in the very short period.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.