Skip to content

Add random suffix to coverage reports #33605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 2 commits into from
Aug 22, 2023
Merged

Add random suffix to coverage reports #33605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a53d04
Add random suffix for coverage reports
Taragolis Aug 22, 2023
06c1f0d
Minor tweaks: enable MySQL coverage, disable Helm, increase color range
Taragolis Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -886,7 +886,7 @@ jobs:
DB_RESET: "false"
PYTHON_MAJOR_MINOR_VERSION: "${{needs.build-info.outputs.default-python-version}}"
JOB_ID: "helm-tests"
COVERAGE: "${{needs.build-info.outputs.run-coverage}}"
COVERAGE: "false" # We do not need to run coverage on Helm tests
Copy link
Contributor Author

@Taragolis Taragolis Aug 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have --no-cov option for Helm, this change just in case

if: >
needs.build-info.outputs.needs-helm-tests == 'true' &&
(github.repository == 'apache/airflow' || github.event_name != 'schedule') &&
Expand Down Expand Up @@ -1089,6 +1089,7 @@ jobs:
MYSQL_VERSION: "${{matrix.mysql-version}}"
BACKEND_VERSION: "${{matrix.mysql-version}}"
JOB_ID: "mysql-${{matrix.mysql-version}}-${{matrix.python-version}}"
COVERAGE: "${{needs.build-info.outputs.run-coverage}}"
if: needs.build-info.outputs.run-tests == 'true'
steps:
- name: Cleanup repo
Expand Down
3 changes: 2 additions & 1 deletion Dockerfile.ci
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1020,10 +1020,11 @@ else
fi

if [[ ${ENABLE_TEST_COVERAGE:="false"} == "true" ]]; then
_suffix="$(head /dev/urandom | tr -dc A-Za-z0-9 | head -c 8)"
EXTRA_PYTEST_ARGS+=(
"--cov=airflow"
"--cov-config=pyproject.toml"
"--cov-report=xml:/files/coverage-${TEST_TYPE/\[*\]/}-${BACKEND}.xml"
"--cov-report=xml:/files/coverage-${TEST_TYPE/\[*\]/}-${BACKEND}-${_suffix}.xml"
)
fi

Expand Down
2 changes: 1 addition & 1 deletion codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ codecov:
coverage:
precision: 2
round: down
range: 55..80
range: 60..85
status:
project:
default:
Expand Down
3 changes: 2 additions & 1 deletion scripts/docker/entrypoint_ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,10 +400,11 @@ else
fi

if [[ ${ENABLE_TEST_COVERAGE:="false"} == "true" ]]; then
_suffix="$(head /dev/urandom | tr -dc A-Za-z0-9 | head -c 8)"
EXTRA_PYTEST_ARGS+=(
"--cov=airflow"
"--cov-config=pyproject.toml"
"--cov-report=xml:/files/coverage-${TEST_TYPE/\[*\]/}-${BACKEND}.xml"
"--cov-report=xml:/files/coverage-${TEST_TYPE/\[*\]/}-${BACKEND}-${_suffix}.xml"
)
fi

Expand Down