[FEATURE] Added oauth support with snowflake sql api operator#36650
[FEATURE] Added oauth support with snowflake sql api operator#36650ighoshsubho wants to merge 2 commits intoapache:mainfrom
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
|
You need to add tests, it makes little sense to run CI if there are no tests added for it. |
|
Closed by mistake. |
sure will do it |
dirrao
left a comment
There was a problem hiding this comment.
Existing test cases are failing. Can you address them?
eladkal
left a comment
There was a problem hiding this comment.
We also need to update the snowflake docs
I am not sure if this goes in the connection part or in the operator part
https://airflow.apache.org/docs/apache-airflow-providers-snowflake/stable/connections/snowflake.html
https://airflow.apache.org/docs/apache-airflow-providers-snowflake/stable/operators/index.html
feel free to suggest the best place to set it
please check now |
|
@ighoshsubho it still missing tests and docs. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
|
Closed in favor of #37922 |
Functionality added -
closes: #36621
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.