Skip to content

[FEATURE] Added oauth support with snowflake sql api operator#36650

Closed
ighoshsubho wants to merge 2 commits intoapache:mainfrom
ighoshsubho:feature-oauth-snowflake-branch
Closed

[FEATURE] Added oauth support with snowflake sql api operator#36650
ighoshsubho wants to merge 2 commits intoapache:mainfrom
ighoshsubho:feature-oauth-snowflake-branch

Conversation

@ighoshsubho
Copy link

Functionality added -

  • SnowflakeSqlApiOperator support for OAuth

closes: #36621


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:snowflake Issues related to Snowflake provider labels Jan 7, 2024
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 7, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk
Copy link
Member

potiuk commented Jan 7, 2024

You need to add tests, it makes little sense to run CI if there are no tests added for it.

@potiuk potiuk closed this Jan 7, 2024
@potiuk potiuk reopened this Jan 7, 2024
@potiuk
Copy link
Member

potiuk commented Jan 7, 2024

Closed by mistake.

@ighoshsubho
Copy link
Author

You need to add tests, it makes little sense to run CI if there are no tests added for it.

sure will do it

Copy link
Contributor

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existing test cases are failing. Can you address them?

Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update the snowflake docs
I am not sure if this goes in the connection part or in the operator part
https://airflow.apache.org/docs/apache-airflow-providers-snowflake/stable/connections/snowflake.html

https://airflow.apache.org/docs/apache-airflow-providers-snowflake/stable/operators/index.html

feel free to suggest the best place to set it

@ighoshsubho
Copy link
Author

Existing test cases are failing. Can you address them?

please check now

@eladkal
Copy link
Contributor

eladkal commented Jan 19, 2024

@ighoshsubho it still missing tests and docs.
Can you add it?

@github-actions
Copy link

github-actions bot commented Mar 5, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Mar 5, 2024
@eladkal
Copy link
Contributor

eladkal commented Mar 6, 2024

Closed in favor of #37922

@eladkal eladkal closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:snowflake Issues related to Snowflake provider stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SnowflakeSqlApiOperator does not support OAuth

4 participants