Fix KeyError when KPO exits too soon#37508
Merged
jscheffl merged 1 commit intoapache:mainfrom Feb 17, 2024
Merged
Conversation
7f1aaed to
4b09017
Compare
33 tasks
jscheffl
approved these changes
Feb 17, 2024
1 task
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On occasions where the pod terminates quickly on pod failure, instead of an AirflowException being raised, we see a KeyError exception:
The reason for this is because this TriggerEvent payload does not pass a
messagefield which is expected here.Granted, this is not really a big problem. The next line is the raise anyways. It's just a bit confusing to the user.
This fixes the missing message KeyError so that we see the proper exception getting raised:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.