Skip to content

Fix KeyError when KPO exits too soon #37508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jscheffl merged 1 commit into from
Feb 17, 2024
Merged

Fix KeyError when KPO exits too soon #37508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion airflow/providers/cncf/kubernetes/triggers/pod.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,12 @@ async def _wait_for_container_completion(self) -> TriggerEvent:
)
elif container_state == ContainerState.FAILED:
return TriggerEvent(
{"status": "failed", "namespace": self.pod_namespace, "name": self.pod_name}
{
"status": "failed",
"namespace": self.pod_namespace,
"name": self.pod_name,
"message": "Container state failed",
}
)
if time_get_more_logs and datetime.datetime.now(tz=datetime.timezone.utc) > time_get_more_logs:
return TriggerEvent(
Expand Down
9 changes: 8 additions & 1 deletion tests/providers/cncf/kubernetes/triggers/test_pod.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,14 @@ async def test_run_loop_return_failed_event(self, mock_hook, mock_method, mock_w
)
mock_method.return_value = ContainerState.FAILED

expected_event = TriggerEvent({"status": "failed", "namespace": "default", "name": "test-pod-name"})
expected_event = TriggerEvent(
{
"status": "failed",
"namespace": "default",
"name": "test-pod-name",
"message": "Container state failed",
}
)
actual_event = await trigger.run().asend(None)

assert actual_event == expected_event
Expand Down