[helm] allow digest for pod_template image#42348
[helm] allow digest for pod_template image#42348josedev-union wants to merge 1 commit intoapache:mainfrom
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
6f46a98 to
fb61594
Compare
| {{- if $digest }} | ||
| {{- printf "%s@%s" $repository $digest -}} | ||
| {{- else }} | ||
| {{- printf "%s:%s" $repository $tag -}} | ||
| {{- end }} |
There was a problem hiding this comment.
I think that if we already fix this, we should also check if there's a tag, and if both (digest and tag) are missing, it would raise an error.
|
I tested with this patch in staging env and realized that worker container image is decided by So I don't think this is needed. My intention was to use digest without a certain tag for worker containers. |
|
I think this is another way to get what you want. |
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.