Skip to content

[helm] allow digest for pod_template image #42348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
josedev-union wants to merge 1 commit into from
Closed

[helm] allow digest for pod_template image #42348

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion chart/templates/_helpers.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,14 @@ If release name contains chart name it will be used as a full name.
{{- end }}

{{- define "pod_template_image" -}}
{{- printf "%s:%s" (.Values.images.pod_template.repository | default .Values.defaultAirflowRepository) (.Values.images.pod_template.tag | default .Values.defaultAirflowTag) }}
{{- $repository := .Values.images.pod_template.repository | default .Values.defaultAirflowRepository -}}
{{- $tag := .Values.images.pod_template.tag | default .Values.defaultAirflowTag -}}
{{- $digest := .Values.images.pod_template.digest | default .Values.defaultAirflowDigest -}}
{{- if $digest }}
{{- printf "%s@%s" $repository $digest -}}
{{- else }}
{{- printf "%s:%s" $repository $tag -}}
{{- end }}
Comment on lines +342 to +346
Copy link
Contributor

@Avihais12344 Avihais12344 Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that if we already fix this, we should also check if there's a tag, and if both (digest and tag) are missing, it would raise an error.

{{- end }}

{{/* This helper is used for airflow containers that do not need the users code */}}
Expand Down