Merged
Conversation
More code
pierrejeambrun
requested review from
bbovenzi,
ephraimbuddy,
jscheffl and
ryanahamilton
as code owners
bbovenzi
approved these changes
Dec 18, 2024
Contributor
bbovenzi
left a comment
bbovenzi
left a comment
There was a problem hiding this comment.
Just a few small comments. Otherwise lgtm
jscheffl
reviewed
Dec 18, 2024
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Works in general, some comments as finding.
Member
Author
|
Comments addressed, screenshot updated. |
Contributor
|
Cool! |
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
* Add clear dag run to UI More code * Small adjustments * Update following code reviews
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the clear dag run button for all tasks and only failed ones.
Closes:
#44859
I'll follow up by adding the capabilities to add / update the note of the run when clearing it.