Swap connections_get CLI command to use Connection instead of BaseHook from sdk#53632
Merged
potiuk merged 1 commit intoapache:mainfrom Jul 22, 2025
Merged
Conversation
amoghrajesh
changed the title
connections_get CLI command to use Connection instead of BaseHoo…connections_get CLI command to use Connection instead of BaseHook from sdk
potiuk
approved these changes
Jul 22, 2025
github-project-automation
bot
moved this from In Progress
to Done
in AIP-72 - Task Execution Interface and SDK
kyungjunleeme
pushed a commit
to kyungjunleeme/airflow
that referenced
this pull request
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
connections_getCLI command imports and uses basehook from sdk when there is no need to do so. It can just use the models.Connection as the utility will most likely not be used on worker.This cuts down a tie between task SDK & core and also removed an unwanted
mock_supervisor_commsusage in tests. Core tests shouldn't need that.If a worker backend is set up, when the connections module moved to using task sdk connection, that will be handled in bulk.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.