Skip to content

Swap connections_get CLI command to use Connection instead of BaseHook from sdk #53632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Jul 22, 2025
Merged

Swap connections_get CLI command to use Connection instead of BaseHook from sdk #53632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions airflow-core/src/airflow/cli/commands/connection_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,7 @@ def _connection_mapper(conn: Connection) -> dict[str, Any]:
def connections_get(args):
"""Get a connection."""
try:
from airflow.sdk import BaseHook

conn = BaseHook.get_connection(args.conn_id)
conn = Connection.get_connection_from_secrets(args.conn_id)
except AirflowNotFoundException:
raise SystemExit("Connection not found.")
AirflowConsole().print_as(
Expand Down
5 changes: 2 additions & 3 deletions airflow-core/tests/unit/cli/commands/test_connection_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@

from airflow.cli import cli_config, cli_parser
from airflow.cli.commands import connection_command
from airflow.exceptions import AirflowException, AirflowNotFoundException
from airflow.exceptions import AirflowException
from airflow.models import Connection
from airflow.utils.db import merge_conn
from airflow.utils.session import create_session
Expand Down Expand Up @@ -61,8 +61,7 @@ def test_cli_connection_get(self):
stdout = stdout.getvalue()
assert "google-cloud-platform:///default" in stdout

def test_cli_connection_get_invalid(self, mock_supervisor_comms):
mock_supervisor_comms.send.side_effect = AirflowNotFoundException
def test_cli_connection_get_invalid(self):
with pytest.raises(SystemExit, match=re.escape("Connection not found.")):
connection_command.connections_get(self.parser.parse_args(["connections", "get", "INVALID"]))

Expand Down