Skip to content

Don't attempt HTTP retries when using the InProcess API client#54543

Merged
ashb merged 1 commit intoapache:mainfrom
astronomer:no-retries-inprocess
Aug 15, 2025
Merged

Don't attempt HTTP retries when using the InProcess API client#54543
ashb merged 1 commit intoapache:mainfrom
astronomer:no-retries-inprocess

Conversation

@ashb
Copy link
Member

@ashb ashb commented Aug 15, 2025

The retries are designed to deal with transient HTTP and network errors, but
when we have the API server running in the same process (in tests, or in
dag.test, ti.run etc) retries are just a waste of time.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

The retries are designed to deal with transient HTTP and network errors, but
when we have the API server running in the same process (in tests, or in
`dag.test`, `ti.run` etc) retries are just a waste of time.
@ashb ashb force-pushed the no-retries-inprocess branch from cd72b4e to a025bce Compare August 15, 2025 12:28
Copy link
Member

@feluelle feluelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding tests.

@ashb ashb merged commit d21a6c0 into apache:main Aug 15, 2025
76 checks passed
@ashb ashb deleted the no-retries-inprocess branch August 15, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants