Skip to content

[AIRFLOW-1740] Fix xcom creation and update via RBAC UI#5560

Merged
ashb merged 1 commit into
apache:v1-10-stablefrom
feluelle:bug-fix/AIRFLOW-1740-xcom-creation-update-via-rbac-ui
Jul 11, 2019
Merged

[AIRFLOW-1740] Fix xcom creation and update via RBAC UI#5560
ashb merged 1 commit into
apache:v1-10-stablefrom
feluelle:bug-fix/AIRFLOW-1740-xcom-creation-update-via-rbac-ui

Conversation

@feluelle
Copy link
Copy Markdown
Member

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-1740
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Fixes the xcom creation and update via the RBAC UI.
It fixes two issues:

  1. sqlalchemy.exc.StatementError: (builtins.TypeError) memoryview: a bytes-like object is required, not 'str' [SQL: 'INSERT INTO xcom ("key", value, timestamp, execution_date, task_id, dag_id) VALUES (?, ?, ?, ?, ?, ?)'] [parameters: [{'value': 'value1', 'dag_id': 'example_bash_operator', 'key': 'key1', 'execution_date': datetime.datetime(2019, 7, 4, 16, 42, 23), 'task_id': 'run_me_0'}]]
  2. sqlalchemy.exc.StatementError: (builtins.ValueError) naive datetime is disallowed [SQL: 'INSERT INTO xcom (key, value, timestamp, execution_date, task_id, dag_id) VALUES (%(key)s, %(value)s, %(timestamp)s, %(execution_date)s, %(task_id)s, %(dag_id)s) RETURNING xcom.id'] [parameters: [{'task_id': 'run_me_0', 'value': 'value1', 'dag_id': 'example_bash_operator', 'key': 'key1', 'execution_date': datetime.datetime(2019, 7, 4, 16, 30, 54)}]]

cc @ashb

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@ashb ashb merged commit b8a0300 into apache:v1-10-stable Jul 11, 2019
@feluelle feluelle deleted the bug-fix/AIRFLOW-1740-xcom-creation-update-via-rbac-ui branch July 13, 2019 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants