Skip to content

[AIRFLOW-1740] Fix xcom creation and update via RBAC UI (master)#5561

Merged
ashb merged 1 commit into
apache:masterfrom
feluelle:bug-fix/AIRFLOW-1740-xcom-creation-update-via-rbac-ui-master
Jul 11, 2019
Merged

[AIRFLOW-1740] Fix xcom creation and update via RBAC UI (master)#5561
ashb merged 1 commit into
apache:masterfrom
feluelle:bug-fix/AIRFLOW-1740-xcom-creation-update-via-rbac-ui-master

Conversation

@feluelle
Copy link
Copy Markdown
Member

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-1740
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Same as #5560 but targeted master branch

cc @ashb

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #5561 into master will decrease coverage by <.01%.
The diff coverage is 58.82%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5561      +/-   ##
=========================================
- Coverage      79%     79%   -0.01%     
=========================================
  Files         489     489              
  Lines       30733   30741       +8     
=========================================
+ Hits        24282   24287       +5     
- Misses       6451    6454       +3
Impacted Files Coverage Δ
airflow/www/views.py 75.15% <42.85%> (-0.16%) ⬇️
airflow/models/xcom.py 80.39% <70%> (+0.19%) ⬆️
airflow/models/taskinstance.py 93.18% <0%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f41eb7...60ace51. Read the comment docs.

@ashb ashb merged commit f29c7fc into apache:master Jul 11, 2019
ashb pushed a commit that referenced this pull request Jul 11, 2019
@feluelle feluelle deleted the bug-fix/AIRFLOW-1740-xcom-creation-update-via-rbac-ui-master branch July 13, 2019 09:38
andriisoldatenko pushed a commit to andriisoldatenko/airflow that referenced this pull request Jul 26, 2019
wmorris75 pushed a commit to modmed-external/incubator-airflow that referenced this pull request Jul 29, 2019
dharamsk pushed a commit to postmates/airflow that referenced this pull request Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants