SQLA2: fix mypy issue with getting the dialect name#56941
Merged
vincbeck merged 2 commits intoapache:mainfrom Oct 21, 2025
Merged
SQLA2: fix mypy issue with getting the dialect name#56941vincbeck merged 2 commits intoapache:mainfrom
vincbeck merged 2 commits intoapache:mainfrom
Conversation
Dev-iL
requested review from
XD-DENG,
ashb,
bugraoz93,
ephraimbuddy,
jason810496,
jedcunningham,
pierrejeambrun,
rawwar and
shubhamraj-git
as code owners
boring-cyborg
bot
added
area:API
Collaborator
Author
|
The failure is unrelated to the changes, and will be fixed by #56944 |
vincbeck
approved these changes
Oct 21, 2025
pierrejeambrun
approved these changes
Oct 21, 2025
Dev-iL
force-pushed
the
2510/sqla2_dialect_retrieval
branch
2 times, most recently
from
05e3e7a to
c4b3238
Compare
vincbeck
added
the
all versions
Dev-iL
force-pushed
the
2510/sqla2_dialect_retrieval
branch
from
c4b3238 to
a41665c
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the 8 instances of the error below across airflow-core
related: #56735
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.