SQLA2: fix mypy violations in api_fastapi/.../calendar.py#56944
Merged
vincbeck merged 1 commit intoapache:mainfrom Oct 21, 2025
Merged
SQLA2: fix mypy violations in api_fastapi/.../calendar.py#56944vincbeck merged 1 commit intoapache:mainfrom
api_fastapi/.../calendar.py#56944vincbeck merged 1 commit intoapache:mainfrom
Conversation
Dev-iL
requested review from
bugraoz93,
ephraimbuddy,
jason810496,
pierrejeambrun,
rawwar and
shubhamraj-git
as code owners
Dev-iL
force-pushed
the
2510/sqla2_fastapi_calendar
branch
from
ef2aca5 to
4555e81
Compare
potiuk
approved these changes
Oct 21, 2025
pierrejeambrun
approved these changes
Oct 21, 2025
vincbeck
reviewed
Oct 21, 2025
airflow-core/src/airflow/api_fastapi/core_api/services/ui/calendar.py
Outdated
Show resolved
Hide resolved
Dev-iL
force-pushed
the
2510/sqla2_fastapi_calendar
branch
from
4555e81 to
7380b02
Compare
Contributor
|
Great job! Fixing those mypy errors really helps make the code cleaner and easier to follow. The type hints around the SQLAlchemy session and queries look much clearer now. |
vincbeck
approved these changes
Oct 21, 2025
jason810496
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #56735
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.