Skip to content

Conversation

@Miretpl
Copy link
Contributor

@Miretpl Miretpl commented Jan 25, 2026

related: #28880

The goal of this PR is to remove the breaking change behaviour introduced by the values under workers.celery, which have a default that differs from nil.

Some test cases were deleted, as they were checking logic for breaking change behaviour.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Jan 25, 2026
@Miretpl Miretpl changed the title Remove helm breaking change Remove workers.celery breaking change Jan 25, 2026
@Miretpl
Copy link
Contributor Author

Miretpl commented Jan 25, 2026

A different proposition for fix can be found in #61040

@Miretpl Miretpl marked this pull request as ready for review January 25, 2026 23:10
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume your PR is a bit leaner. Have no time to thorowly inspect, need to get to bed now finally. Except 3 comments nothing bad obviously seen.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bugraoz93 bugraoz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to review and revert the PR before release, as discussed in Slack. Thanks a lot for the PR! 🙏

@jedcunningham jedcunningham merged commit 685f686 into apache:main Jan 26, 2026
143 of 146 checks passed
@Miretpl Miretpl deleted the remove-helm-breaking-change branch January 26, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants