-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Remove workers.celery breaking change #61049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove workers.celery breaking change #61049
Conversation
|
A different proposition for fix can be found in #61040 |
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume your PR is a bit leaner. Have no time to thorowly inspect, need to get to bed now finally. Except 3 comments nothing bad obviously seen.
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bugraoz93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to review and revert the PR before release, as discussed in Slack. Thanks a lot for the PR! 🙏
related: #28880
The goal of this PR is to remove the breaking change behaviour introduced by the values under
workers.celery, which have a default that differs from nil.Some test cases were deleted, as they were checking logic for breaking change behaviour.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.