Restore deactivate_deleted_dags signature broken by #63617#64245
Merged
ephraimbuddy merged 1 commit intoapache:mainfrom Mar 26, 2026
Merged
Restore deactivate_deleted_dags signature broken by #63617#64245ephraimbuddy merged 1 commit intoapache:mainfrom
deactivate_deleted_dags signature broken by #63617#64245ephraimbuddy merged 1 commit intoapache:mainfrom
Conversation
ephraimbuddy
requested review from
XD-DENG,
ashb and
jedcunningham
as code owners
The zip import error fix (apache#63617) changed the public signature of `DagFileProcessorManager.deactivate_deleted_dags` from `(bundle_name, present: set[DagFileInfo])` to `(bundle_name, observed_filelocs: set[str])`, breaking subclass overrides. Restore the original signature and compute observed filelocs internally. Also widen `DagModel.deactivate_deleted_dags` `rel_filelocs` type from `set[str]` to `Collection[str]` to accept both list and set callers.
ephraimbuddy
force-pushed
the
fix-backward-incompatibility
branch
from
1d93e4a to
799e2c1
Compare
kaxil
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The zip import error fix (#63617) changed the public signature of
DagFileProcessorManager.deactivate_deleted_dagsfrom(bundle_name, present: set[DagFileInfo])to(bundle_name, observed_filelocs: set[str]), breaking subclass overrides. Restore the original signature and compute observed filelocs internally.Also widen
DagModel.deactivate_deleted_dagsrel_filelocstype fromset[str]toCollection[str]to accept both list and set callers.