fix infinite loop for limit<0 for all list operations in airflowctl#64582
Merged
potiuk merged 1 commit intoapache:mainfrom Apr 1, 2026
Merged
fix infinite loop for limit<0 for all list operations in airflowctl#64582potiuk merged 1 commit intoapache:mainfrom
potiuk merged 1 commit intoapache:mainfrom
Conversation
rjgoyln
requested review from
bugraoz93,
dheerajturaga and
potiuk
as code owners
henry3260
approved these changes
Apr 1, 2026
Contributor
henry3260
left a comment
henry3260
left a comment
There was a problem hiding this comment.
LGTM Thanks for the PR!
bugraoz93
approved these changes
Apr 1, 2026
Contributor
bugraoz93
left a comment
bugraoz93
left a comment
There was a problem hiding this comment.
Awesome, thanks for the fix!
bugraoz93
changed the title
potiuk
approved these changes
Apr 1, 2026
Subham-KRLX
pushed a commit
to Subham-KRLX/airflow
that referenced
this pull request
Apr 3, 2026
Suraj-kumar00
pushed a commit
to Suraj-kumar00/airflow
that referenced
this pull request
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prevent infinite loop by validating limit in pagination logic
Description
In operations.py at line 217, the offset is incremented by limit in each iteration. However, there is currently no validation to ensure limit is a positive integer.
Changes
raise a
ValueErrorif an invalid limit is provided.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.