Skip to content

fix infinite loop for limit<0 for all list operations in airflowctl #64582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Apr 1, 2026
Merged

fix infinite loop for limit<0 for all list operations in airflowctl #64582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions airflow-ctl/src/airflowctl/api/operations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,9 @@ def __init_subclass__(cls, **kwargs):
setattr(cls, attr, _check_flag_and_exit_if_server_response_error(value))

def execute_list(self, *, path, data_model, offset=0, limit=50, params=None):
if limit <= 0:
raise ValueError(f"limit must be a positive integer, got {limit}")

shared_params = {"limit": limit, **(params or {})}

def safe_validate(content: bytes) -> BaseModel:
Expand Down
10 changes: 10 additions & 0 deletions airflow-ctl/tests/airflow_ctl/api/test_operations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,16 @@ def test_execute_list_sends_limit_on_subsequent_pages(self):
for call in mock_client.get.call_args_list:
assert call.kwargs["params"]["limit"] == 2

@pytest.mark.parametrize("limit", [0, -1])
def test_execute_list_rejects_non_positive_limit(self, limit):
mock_client = Mock()
base_operation = BaseOperations(client=mock_client)

with pytest.raises(ValueError, match="limit must be a positive integer"):
base_operation.execute_list(path="hello", data_model=HelloCollectionResponse, limit=limit)

mock_client.get.assert_not_called()


class TestAssetsOperations:
asset_id: int = 1
Expand Down
Loading