Use set for llm_completed and remove dead pending branch in TUI#64585
Merged
potiuk merged 1 commit intoapache:mainfrom Apr 1, 2026
Merged
Use set for llm_completed and remove dead pending branch in TUI#64585potiuk merged 1 commit intoapache:mainfrom
potiuk merged 1 commit intoapache:mainfrom
Conversation
Switch llm_completed from list to set so the membership check in _collect_llm_results runs in O(1) instead of O(n) per poll cycle. Remove unreachable duplicate elif for llm_status == "pending" in the TUI PR table builder. Signed-off-by: André Ahlert <andre@aex.partners>
andreahlert
requested review from
amoghrajesh,
ashb,
bugraoz93,
choo121600,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
jscheffl,
potiuk and
vatsrahul1001
as code owners
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-2-test
potiuk
approved these changes
Apr 1, 2026
Contributor
Backport failed to create: v3-2-test. View the failure log Run detailsNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
You can attempt to backport this manually by running: cherry_picker 6bd6fdf v3-2-testThis should apply the commit to the v3-2-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
Subham-KRLX
pushed a commit
to Subham-KRLX/airflow
that referenced
this pull request
Apr 3, 2026
…he#64585) Switch llm_completed from list to set so the membership check in _collect_llm_results runs in O(1) instead of O(n) per poll cycle. Remove unreachable duplicate elif for llm_status == "pending" in the TUI PR table builder. Signed-off-by: André Ahlert <andre@aex.partners>
Suraj-kumar00
pushed a commit
to Suraj-kumar00/airflow
that referenced
this pull request
Apr 7, 2026
…he#64585) Switch llm_completed from list to set so the membership check in _collect_llm_results runs in O(1) instead of O(n) per poll cycle. Remove unreachable duplicate elif for llm_status == "pending" in the TUI PR table builder. Signed-off-by: André Ahlert <andre@aex.partners>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
llm_completed is checked on every poll cycle to filter out already-collected futures, and as a list that check is O(n) per future which gets noticeable with larger batches.
llm_completedis used to track which LLM futures have already been collected. It was a list, so thef not in llm_completedcheck in_collect_llm_resultswas O(n) on every poll cycle,. With many PRs this adds up. Switched to a set for O(1) lookup. No behavior change since the container is never iterated, indexed, or ordered.Also removed a duplicate
elif entry.llm_status == "pending"branch in the TUI PR table builder that was shadowed by an earlier branch in the same chain and could never execute.Test plan
breeze pr auto-triage --tuiworks as beforeWas generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments.