Skip to content

Use set for llm_completed and remove dead pending branch in TUI #64585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Apr 1, 2026
+5 −7
Merged

Use set for llm_completed and remove dead pending branch in TUI #64585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions dev/breeze/src/airflow_breeze/commands/pr_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2670,7 +2670,7 @@ def _llm_progress_status(completed: int, total: int, flagged: int, errors: int)
def _collect_llm_results(
future_to_pr: dict,
llm_assessments: dict,
llm_completed: list[int],
llm_completed: set,
llm_errors: list[int],
llm_passing: list,
block: bool = False,
Expand All @@ -2692,7 +2692,7 @@ def _collect_llm_results(

done_futures = [f for f in future_to_pr if f.done() and f not in llm_completed]
for future in done_futures:
llm_completed.append(future)
llm_completed.add(future)
pr = future_to_pr[future]
try:
assessment = future.result()
Expand Down Expand Up @@ -2777,7 +2777,7 @@ class TriageContext:
# LLM background state
llm_future_to_pr: dict
llm_assessments: dict
llm_completed: list
llm_completed: set
llm_errors: list[int]
llm_passing: list
# LLM durations: PR number → actual execution time in seconds
Expand Down Expand Up @@ -8762,7 +8762,7 @@ def _launch_llm_and_build_context(
"""Launch LLM executor for candidates and build a TriageContext."""
llm_future_to_pr: dict = {}
llm_assessments: dict[int, PRAssessment] = {}
llm_completed: list = []
llm_completed: set = set()
llm_errors: list[int] = []
llm_passing: list[PRData] = []
llm_executor = None
Expand Down Expand Up @@ -10302,7 +10302,7 @@ def _cb(completed: int, total: int) -> None:
main_failures=main_failures,
llm_future_to_pr={},
llm_assessments={},
llm_completed=[],
llm_completed=set(),
llm_errors=[],
llm_passing=[],
)
Expand Down
2 changes: 0 additions & 2 deletions dev/breeze/src/airflow_breeze/utils/tui_display.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -729,8 +729,6 @@ def _build_pr_table(self, visible_rows: int) -> Panel:
llm_text = "[red]error[/]"
elif entry.llm_status == "disabled":
llm_text = "[dim]disabled[/]"
elif entry.llm_status == "pending":
llm_text = "[dim]queued[/]"
else:
llm_text = "[dim]—[/]"

Expand Down
Loading