Skip to content

[AIRFLOW-5827] Move build to later stage in pre-commit#6493

Merged
potiuk merged 1 commit into
apache:masterfrom
PolideaInternal:move-build-image-to-later-stage
Nov 4, 2019
Merged

[AIRFLOW-5827] Move build to later stage in pre-commit#6493
potiuk merged 1 commit into
apache:masterfrom
PolideaInternal:move-build-image-to-later-stage

Conversation

@potiuk
Copy link
Copy Markdown
Member

@potiuk potiuk commented Nov 4, 2019

This change is to move build stage of pre-commit as late as possible in pre-commit
chain. This is useful if you do not want to rebuild the docker images needed
to run pylint/mypy/flake8 - and still see the result of other checks immediately
after you run commit.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-5827
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@potiuk potiuk changed the title [AIRFLOW-5827] Move build to later stage in pre-commit …Move build image to later stage [AIRFLOW-5827] Move build to later stage in pre-commit. Depends on [AIRFLOW-5826] [AIRFLOW-5839] Nov 4, 2019
@potiuk potiuk requested a review from mik-laj November 4, 2019 08:51
@potiuk potiuk changed the title [AIRFLOW-5827] Move build to later stage in pre-commit. Depends on [AIRFLOW-5826] [AIRFLOW-5839] [AIRFLOW-5827] Move build to later stage in pre-commit. Depends on [AIRFLOW-5826] Nov 4, 2019
@potiuk potiuk force-pushed the move-build-image-to-later-stage branch from 974f237 to 00a3470 Compare November 4, 2019 08:55
This change is to move build stage of pre-commit as late as possible in pre-commit
chain. This is useful if you do not want to rebuild the docker images needed
to run pylint/mypy/flake8 - and still see the result of other checks immediately
after you run commit.
@potiuk potiuk force-pushed the move-build-image-to-later-stage branch from 00a3470 to 28dd126 Compare November 4, 2019 09:52
@potiuk potiuk changed the title [AIRFLOW-5827] Move build to later stage in pre-commit. Depends on [AIRFLOW-5826] [AIRFLOW-5827] Move build to later stage in pre-commit Nov 4, 2019
@potiuk potiuk merged commit 45e108d into apache:master Nov 4, 2019
potiuk added a commit that referenced this pull request Nov 4, 2019
This change is to move build stage of pre-commit as late as possible in pre-commit
chain. This is useful if you do not want to rebuild the docker images needed
to run pylint/mypy/flake8 - and still see the result of other checks immediately
after you run commit.

(cherry picked from commit 45e108d)
potiuk added a commit that referenced this pull request Nov 5, 2019
This change is to move build stage of pre-commit as late as possible in pre-commit
chain. This is useful if you do not want to rebuild the docker images needed
to run pylint/mypy/flake8 - and still see the result of other checks immediately
after you run commit.

(cherry picked from commit 45e108d)
potiuk added a commit that referenced this pull request Nov 5, 2019
This change is to move build stage of pre-commit as late as possible in pre-commit
chain. This is useful if you do not want to rebuild the docker images needed
to run pylint/mypy/flake8 - and still see the result of other checks immediately
after you run commit.

(cherry picked from commit 45e108d)
potiuk added a commit that referenced this pull request Nov 5, 2019
This change is to move build stage of pre-commit as late as possible in pre-commit
chain. This is useful if you do not want to rebuild the docker images needed
to run pylint/mypy/flake8 - and still see the result of other checks immediately
after you run commit.

(cherry picked from commit 45e108d)
potiuk added a commit that referenced this pull request Nov 12, 2019
This change is to move build stage of pre-commit as late as possible in pre-commit
chain. This is useful if you do not want to rebuild the docker images needed
to run pylint/mypy/flake8 - and still see the result of other checks immediately
after you run commit.

(cherry picked from commit 45e108d)
eladkal pushed a commit to eladkal/airflow that referenced this pull request Dec 2, 2019
This change is to move build stage of pre-commit as late as possible in pre-commit
chain. This is useful if you do not want to rebuild the docker images needed
to run pylint/mypy/flake8 - and still see the result of other checks immediately
after you run commit.

(cherry picked from commit 45e108d)
kaxil pushed a commit that referenced this pull request Dec 12, 2019
This change is to move build stage of pre-commit as late as possible in pre-commit
chain. This is useful if you do not want to rebuild the docker images needed
to run pylint/mypy/flake8 - and still see the result of other checks immediately
after you run commit.

(cherry picked from commit 45e108d)
@potiuk potiuk added the area:production-image Production image improvements and fixes label Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:production-image Production image improvements and fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants