Add workers.celery.topologySpreadConstraints & workers.kubernetes.topologySpreadConstraints#64980
Merged
jscheffl merged 3 commits intoapache:mainfrom Apr 11, 2026
Conversation
2 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds executor-specific topology spread constraint configuration for workers in the Helm chart, deprecating the previous shared workers.topologySpreadConstraints field.
Changes:
- Introduces
workers.celery.topologySpreadConstraintsandworkers.kubernetes.topologySpreadConstraintsin values + schema. - Adds deprecation messaging for
workers.topologySpreadConstraints(schema description + Helm NOTES). - Updates Helm tests to validate precedence/overrides for the new fields.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| helm-tests/tests/helm_tests/airflow_core/test_worker_sets.py | Extends test matrix to cover Celery worker-set overrides for topology spread constraints. |
| helm-tests/tests/helm_tests/airflow_core/test_worker.py | Parametrizes worker deployment test to validate deprecated vs new Celery-specific topology spread constraints precedence. |
| helm-tests/tests/helm_tests/airflow_aux/test_pod_template_file.py | Parametrizes pod-template-file test to validate deprecated vs new Kubernetes-specific topology spread constraints precedence. |
| chart/values.yaml | Documents deprecation and adds new values keys for Celery/Kubernetes worker topology spread constraints. |
| chart/values.schema.json | Deprecates old schema description and adds schema entries for new keys. |
| chart/templates/NOTES.txt | Adds a deprecation warning when old workers.topologySpreadConstraints is used. |
| chart/files/pod-template-file.kubernetes-helm-yaml | Switches pod template to prefer workers.kubernetes.topologySpreadConstraints over deprecated/shared fields. |
…ologySpreadConstraints
afae5a9 to
19120ff
Compare
jscheffl
approved these changes
Apr 11, 2026
Backport successfully created: chart/v1-2x-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #28880
This PR introduces two new fields:
workers.celery.topologySpreadConstraintsandworkers.kubernetes.topologySpreadConstraints. Theworkers.topologySpreadConstraintsfield is now deprecated.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.